fix(auth): remove redundant remove guest identityId call #13789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
force-pushed
the
hui/fix/auth/redundant-identity-id-clearing
branch
from
3eae85e
to
3f9d704
Compare
HuiSF
requested review from
ukhan-amazon,
haverchuck,
cshfang and
jimblanc
as code owners
jimblanc
approved these changes
Sep 16, 2024
Samaritan1011001
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change enforces the guest identityId removing function call happens only when the identity ID store has previously stored a guest identity while storing the authenticated identity ID.
Issue #, if available
#13787
Description of how you validated changes
The change enforces clear identityId stora
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.