Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "feat(core): resolve webcrypto from node:crypto for Node18 (#13599)" #13775

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Sep 3, 2024

This reverts commit f8dbc95.

Description of changes

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF merged commit 1fea052 into main Sep 6, 2024
30 checks passed
@HuiSF HuiSF deleted the hui/feat/node-web-crypto branch September 6, 2024 15:58
HuiSF added a commit that referenced this pull request Sep 17, 2024
HuiSF added a commit that referenced this pull request Sep 17, 2024
HuiSF added a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants