chore(auth): add oauth metadata into token orchestrator #13712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
israx
requested review from
ukhan-amazon,
haverchuck,
cshfang,
jimblanc and
HuiSF
as code owners
AllanZhengYP
approved these changes
Aug 14, 2024
HuiSF
reviewed
Aug 14, 2024
packages/auth/src/providers/cognito/utils/oauth/completeOAuthFlow.ts
Outdated
Show resolved
Hide resolved
jimblanc
approved these changes
Aug 14, 2024
jimblanc
reviewed
Aug 14, 2024
| expect(mockOAuthSignOutRedirect).toHaveBeenCalledWith(cognitoConfig); | ||
| }); | ||
|
|
||
| it('should complete OAuth sign out and redirect when there oauth metadata in tokenOrchestrator', async () => { |
There was a problem hiding this comment.
Sanity check: Are there more tests we can add? E.g. signing out of an existing session without this meta-data in storage, error cases, etc.
There was a problem hiding this comment.
The previous tests are already signing out without depending on this metadata in storage already. Further test cases will be introduced by the e2e test
HuiSF
approved these changes
Aug 16, 2024
israx
added a commit
to israx/amplify-js
that referenced
this pull request
Aug 20, 2024
…13712) * chore: add oauth metadata into token orchestrator * chore: add unit tests * chore: address feedback
israx
added a commit
to israx/amplify-js
that referenced
this pull request
Aug 20, 2024
…13712) * chore: add oauth metadata into token orchestrator * chore: add unit tests * chore: address feedback
israx
added a commit
that referenced
this pull request
Aug 20, 2024
* wip: hardcode signout uri for poc * chore: expose the prefferedRedirectSignOutUrl * chore: add prefered url change to native file * chore: correct param name * chore: update getRedirectUrl function to consider preferred url * chore: add unit test for the feature * chore: update input type to use the accepted format * chore: review comments * fix: address npm audit issues * chore: update comments, bundle size and rn version * chore: update bundle size limit * chore: update bundle size limit * chore: address coments and rename a param to getRedirecturl funciton * chore: make preid release ready * chore: update yarn.lock * chore: add test and update push-integ branch * chore: revert preid release updates * chore: update sample name * chore: update yarn.lock * chore(auth): add oauth metadata into token orchestrator (#13712) * chore: add oauth metadata into token orchestrator * chore: add unit tests * chore: address feedback * chore: fix unit tests * chore: enable tests in ci --------- Co-authored-by: ManojNB <manojnb95@gmail.com>
israx
added a commit
to israx/amplify-js
that referenced
this pull request
Aug 20, 2024
…13712) * chore: add oauth metadata into token orchestrator * chore: add unit tests * chore: address feedback
israx
added a commit
to israx/amplify-js
that referenced
this pull request
Aug 21, 2024
…13712) * chore: add oauth metadata into token orchestrator * chore: add unit tests * chore: address feedback
6 tasks
israx
added a commit
that referenced
this pull request
Aug 21, 2024
* chore: enable subdomains e2e test * chore(auth): add oauth metadata into token orchestrator (#13712) * chore: add oauth metadata into token orchestrator * chore: add unit tests * chore: address feedback
Samaritan1011001
added a commit
that referenced
this pull request
Sep 3, 2024
* chore(auth): add oauth metadata into token orchestrator (#13712) (#13736) * chore: add oauth metadata into token orchestrator * chore: add unit tests * chore: address feedback * wip: hardcode signout uri for poc * chore: expose the prefferedRedirectSignOutUrl * chore: add prefered url change to native file * chore: correct param name * chore: update getRedirectUrl function to consider preferred url * chore: add unit test for the feature * chore: update input type to use the accepted format * chore: review comments * fix: address npm audit issues * chore: update comments, bundle size and rn version * chore: update bundle size limit * chore: update bundle size limit * chore: address coments and rename a param to getRedirecturl funciton * chore: make preid release ready * chore: update yarn.lock * chore: add test and update push-integ branch * chore: revert preid release updates * chore: update sample name * chore: enable react native tests with localhost server * chore: enable subdomain test * chore: update some function calls in tests * chore: minor reverts * fix: unit tests fail on mehtod params * chore: revert ppush branch * chore: remove subdomain test rdundant * chore: upadte step name * chore: reflect API changes and clean up * chore: revert unintented change glob * chore: bundle size minor adjustments * chore: move localhost page hosting to RN script in the app * chore: revert unintended change * chore: revert branch name for integ test --------- Co-authored-by: israx <70438514+israx@users.noreply.github.com> Co-authored-by: AllanZhengYP <zheallan@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change adds oauth metadata into the token orchestrator. This metadata is set after the user has authenticated via OAuth, and it can be accessed from the current
KeyValueStorage(LocalStorage, SessionStorage, CookieStorage, etc).Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.