chore: show underlying errors in fetch / xhr #13687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joon-won
requested review from
ukhan-amazon,
haverchuck,
cshfang,
jimblanc,
HuiSF and
a team
as code owners
joon-won
changed the title
AllanZhengYP
reviewed
Aug 7, 2024
AllanZhengYP
reviewed
Aug 7, 2024
packages/storage/src/providers/s3/utils/client/runtime/xhrTransferHandler.ts
Outdated
Show resolved
Hide resolved
AllanZhengYP
previously approved these changes
Aug 9, 2024
added 2 commits
August 14, 2024 12:42
AllanZhengYP
approved these changes
Aug 15, 2024
ashika112
approved these changes
Aug 16, 2024
jimblanc
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Modify error type in
fetchtransfer,xhrhandlerto show underlying errors inApiError.underlyingErrorandStorageError/underlyingErrorrespectively.Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.