feat(storage): add support for content disposition and content type in getUrl #13615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuhengshs
force-pushed
the
yuhengsh-contentDisposition
branch
from
64ca761
to
739a1d4
Compare
yuhengshs
changed the title
yuhengshs
changed the title
yuhengshs
requested review from
ukhan-amazon,
haverchuck,
cshfang,
jimblanc,
HuiSF and
a team
as code owners
ashika112
reviewed
Jul 22, 2024
packages/storage/__tests__/providers/s3/utils/client/S3/getPresignedGetObjectUrl.test.ts
Outdated
Show resolved
Hide resolved
packages/storage/__tests__/providers/s3/utils/client/S3/getPresignedGetObjectUrl.test.ts
Outdated
Show resolved
Hide resolved
…position' into yuhengsh-contentDisposition
ashika112
reviewed
Jul 23, 2024
packages/storage/src/providers/s3/utils/constructContentDisposition.ts
Outdated
Show resolved
Hide resolved
ashika112
previously approved these changes
Jul 24, 2024
HuiSF
reviewed
Jul 24, 2024
packages/storage/src/providers/s3/utils/constructContentDisposition.ts
Outdated
Show resolved
Hide resolved
packages/storage/src/providers/s3/utils/constructContentDisposition.ts
Outdated
Show resolved
Hide resolved
HuiSF
reviewed
Jul 25, 2024
packages/storage/src/providers/s3/utils/constructContentDisposition.ts
Outdated
Show resolved
Hide resolved
HuiSF
reviewed
Jul 25, 2024
HuiSF
reviewed
Jul 25, 2024
packages/storage/src/providers/s3/apis/uploadData/multipart/initialUpload.ts
Outdated
Show resolved
Hide resolved
HuiSF
previously approved these changes
Aug 1, 2024
| @@ -328,20 +328,20 @@ describe('getUrl test with path', () => { | |||
| path: 'path', | |||
| expectedKey: 'path', | |||
| contentDisposition: { | |||
| type: 'invalid' as const, | |||
There was a problem hiding this comment.
TBH const is legit here. 😄 it turns string into invalid, so it conforms the string union.
ashika112
previously approved these changes
Aug 1, 2024
Bump up getUrl package size to 15.63KB
the size exceeded 1B
HuiSF
approved these changes
Aug 6, 2024
ashika112
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
getUrlin Storage category.Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.