Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api-rest): refactor ajax method to not relying on side effects #11498

Merged
merged 7 commits into from
Jul 20, 2023
Merged

fix(api-rest): refactor ajax method to not relying on side effects #11498

merged 7 commits into from
Jul 20, 2023

Commits on Jun 14, 2023

  1. fix(core): make Signer.sign side-effect-ful 

    the previous Signer.sign() implementation not only returns signed
request, but also sets the signed headers to input request. The
recent refactor makes it side-effect-less.

However this change breaks RestClient.ajax() clock skew correction
which relies on the x-amz-date header set by signer to the input
request object to indicate the current client side time.

this fix resolves aws-amplify#11480
    @AllanZhengYP
    AllanZhengYP committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    709c4a5 View commit details
    Browse the repository at this point in the history

  2. Revert "fix(core): make Signer.sign side-effect-ful" 

    This reverts commit 709c4a5.
    @AllanZhengYP
    AllanZhengYP committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    91d263f View commit details
    Browse the repository at this point in the history

  3. fix(api-rest): refactor ajax method to not relying on side effects

    @AllanZhengYP
    AllanZhengYP committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    a14ac21 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into fix-graphql-skew

    @AllanZhengYP
    AllanZhengYP committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    0302220 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into fix-graphql-skew

    @AllanZhengYP
    AllanZhengYP committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    cb62a75 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. Merge branch 'main' into fix-graphql-skew

    @AllanZhengYP
    AllanZhengYP committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    ea0094d View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Merge branch 'main' into fix-graphql-skew

    @AllanZhengYP
    AllanZhengYP committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    2d94b84 View commit details
    Browse the repository at this point in the history