Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datastore with custom claims seems not ok #4928

Closed
SebSchwartz opened this issue Feb 16, 2020 · 8 comments
Closed

Datastore with custom claims seems not ok #4928

SebSchwartz opened this issue Feb 16, 2020 · 8 comments
Labels
DataStore Related to DataStore category to-be-reproduced Used in order for Amplify to reproduce said issue

Comments

@SebSchwartz
Copy link
Contributor

Describe the bug
I configured amplify with custom authorization header to pass idToken with datastore. I configured my schema to work with it but i'm receiving the same error with all models:
0: {errorType: "Unauthorized", message: "Not Authorized to access onUpdateAddress on type Subscription"}.
When I create a new address, i can see it in my indexDB but it's not sent to dynamodb...

To Reproduce
I checked out a new projet with datastore following the docs (to test it out). My cognito user pool does have the custom attribute and my signed in user has a value "1" for it.

Amplify config:

Amplify.configure(awsconfig);

Amplify.configure({
  API: {
    graphql_headers: async () => {
      const session = await Auth.currentSession();
      return {
        Authorization: session.getIdToken().getJwtToken()
      };
    },
  },
});

schema.graphql:

type Address
  @model
  @auth(rules: [{ allow: owner, identityClaim: "custom:clientId" }]) {
  id: ID!
  street: String
}

Expected behavior
Should work and no error should be raised ;)

Screenshots

Environment
  System:
    OS: macOS 10.15.2
    CPU: (8) x64 Intel(R) Core(TM) i7-8559U CPU @ 2.70GHz
    Memory: 1.05 GB / 16.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 10.16.3 - /usr/local/bin/node
    Yarn: 1.17.3 - /usr/local/bin/yarn
    npm: 6.13.4 - /usr/local/bin/npm
  Browsers:
    Chrome: 79.0.3945.130
    Firefox: 62.0
    Safari: 13.0.4
  npmPackages:
    @aws-amplify/analytics: ^2.2.4 => 2.2.4 
    @aws-amplify/core: ^2.2.4 => 2.2.4 
    @aws-amplify/datastore: ^1.0.6 => 1.0.6 
    @testing-library/jest-dom: ^4.2.4 => 4.2.4 
    @testing-library/react: ^9.4.0 => 9.4.0 
    @testing-library/user-event: ^7.2.1 => 7.2.1 
    aws-amplify: ^2.2.4 => 2.2.4 
    aws-amplify-react: ^3.1.5 => 3.1.5 
    ini: ^1.3.5 => 1.3.5 
    inquirer: ^6.5.1 => 6.5.2 
    react: ^16.12.0 => 16.12.0 
    react-dom: ^16.12.0 => 16.12.0 
    react-scripts: 3.3.1 => 3.3.1 
  npmGlobalPackages:
    @aws-amplify/cli: 4.13.3
    apollo: 1.9.2
    aws-appsync-codegen: 0.17.5
    awsmobile-cli: 1.1.5
    expo-cli: 3.11.9
    lerna: 3.13.3
    npm: 6.13.4
    serverless: 1.53.0
    typescript: 3.4.5
    watchman: 1.0.0
    yarn: 1.9.4
@SebSchwartz SebSchwartz added the to-be-reproduced Used in order for Amplify to reproduce said issue label Feb 16, 2020
@SebSchwartz
Copy link
Contributor Author

Here is the message sent for the subscription:

{
id: "5c49fe65-5481-4009-8216-45684ace19fa",
payload: {
data: "{"query":"subscription operation($owner: String!) {\n  onUpdateAddress(owner: $owner) {\n    id\n    street\n    _version\n    _lastChangedAt\n    _deleted\n  }\n}\n","variables":{"owner":"1"}}",
extensions: {
authorization: {
Authorization: "Access TOKEN",
host: ".com",
x-amz-user-agent: "aws-amplify/2.2.4 js"
}}}
type: "start"
}

@SebSchwartz
Copy link
Contributor Author

I also tried with ownerField: "clientId"in the auth config and adding the field in the schema but got the same error :/

@SebSchwartz
Copy link
Contributor Author

I also updated some package version to:

"@aws-amplify/datastore": "^1.0.7",
        "aws-amplify": "^2.2.5",
        "aws-amplify-react": "^3.1.6",

But error is still there with those versions.

@SebSchwartz
Copy link
Contributor Author

It is working with simple key-value header but it's not waiting the result when calling it with async method ->

In the API packages, it's awaited and called after the basic one so we can override it:

...(await graphql_headers({ query, variables })),

@sammartinez sammartinez added the DataStore Related to DataStore category label Feb 20, 2020
jordanranz added a commit that referenced this issue Mar 27, 2020
* Adding database abstraction for AsyncStorage

* Add storage adapter for React Native using AsyncStorage

* Add separate default adapters for Web and React Native

* Make error messages more meaningful

* Add support for Reachability in React Native

* Add @react-native-community/netinfo to devDependencies

* Pin down the version of crypto-js

* Enable publish from rn-datastore branch

* Preparing release

* chore(release): Publish [ci skip]

 - @aws-amplify/analytics@2.2.5
 - aws-amplify-angular@4.1.6
 - aws-amplify-react@3.1.6
 - aws-amplify@2.2.5
 - @aws-amplify/datastore@1.0.7
 - @aws-amplify/pubsub@2.1.6

* Allow in PubSub to add async custom headers

Allow in PubSub the same capabilities as API for custom headers:
* Async header
* Override headers (Authorization)

Check issue #4928 for explanations.

* chore(deps-dev): bump codecov from 1.0.1 to 3.6.5 (#4951)

Bumps [codecov](https://github.com/codecov/codecov-node) from 1.0.1 to 3.6.5.
- [Release notes](https://github.com/codecov/codecov-node/releases)
- [Commits](https://github.com/codecov/codecov-node/commits)

Signed-off-by: dependabot[bot] <support@github.com>

* (fix:@aws-amplify/pubsub) Fix for unsubscription new subscription race condition (#4956)

* Fix for unsubscription new subscription race condition

* Update packages/pubsub/src/Providers/AWSAppSyncRealTimeProvider.ts

* Fix to initialize only once and handle disconnection from network  (#4921)

* initialize only once

* Fix onerror handler for WebSocket

* Change log level for unsubscribe message

* Add regions and fix typo

* Handle disconnection

* chore(deps): bump nokogiri from 1.10.4 to 1.10.8 in /docs (#4974)

Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.10.4 to 1.10.8.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.10.4...v1.10.8)

Signed-off-by: dependabot[bot] <support@github.com>

* Use the db instance property of the Adapter class for all database operations (#4995)

Use the db instance property of the Adapter class for all database operations

* Removing unused code

* Remove rn-datastore branch publish config

* Preparing release

* chore(release): Publish [ci skip]

 - amazon-cognito-identity-js@3.2.5
 - @aws-amplify/analytics@2.2.6
 - @aws-amplify/api@2.1.6
 - @aws-amplify/auth@2.1.6
 - aws-amplify-angular@4.1.7
 - aws-amplify-react@3.1.7
 - aws-amplify@2.2.6
 - @aws-amplify/cache@2.1.6
 - @aws-amplify/core@2.2.5
 - @aws-amplify/datastore@1.0.8
 - @aws-amplify/interactions@2.1.6
 - @aws-amplify/predictions@2.1.6
 - @aws-amplify/pubsub@2.1.7
 - @aws-amplify/pushnotification@2.1.6
 - @aws-amplify/storage@2.2.1
 - @aws-amplify/xr@1.1.6

* fix(core): move react-native dependency from dev

* fix(core): revert dep addition. Add to peer and devDeps

* ci: Add React Native integration testing with Detox (#5007)

* Make deploy wait on integ_rn_ios_storage (#5009)

* feat(@aws-amplify/api): pass additionalHeaders to graphql function (#5001)

Additional headers are merged **after** merging in headers set at config time.
Additional headers will overwrite any existing values and merge the rest.

* chore(@aws-amplify/api): fix non-breaking typo in function (#5034)

* fix(@aws-amplify/datastore): Fix query and delete types (#5032)

Fixes #4827

* Fix(@aws-amplify/interactions) fixes 4750 to properly use the spread operator (#4806)

* fix(@aws-amplify/datastore) Adding socket disconnection detection (#5086)

* Export necessary providers and types from the package root to avoid importing from generated paths (#5085)

* fix(aws-amplify-react): Fix Federated icons when using React Bo… (#5073)

* Explicitly set box-sizing, as CSS resets override to border-box

* Explicitly set line-height, as CSS resets override line-height

* Upgrade aws-sdk clients which resolves react native issues (#5124)

* Export necessary providers and types from the package root to avoid importing from generated paths

* Upgrade aws-sdk clients which resolves react native issues

* Enable integration tests on modularization branch (#5125)

* chore: Fix setup-dev script (#5035)

Let `unlink-all` succeed always

Co-authored-by: Iglesias <manuelig@3c22fb19fec4.ant.amazon.com>

* fix(@aws-amplify/datastore): Storage should be re-initialized after DataStore.clear() (#5083)

* fix(@aws-amplify/datastore): Fix #5076 storage not re-initialized after DataStore.clear()

* Adding comments

Co-authored-by: Manuel Iglesias <manuelig@amazon.com>
Co-authored-by: Ashish Nanda <ashish.nanda.5591@gmail.com>

* fix(aws-amplify-react): BREAKING - Remove "import '@aws-amplify… (#5138)

Importing non-JS files relies on a bundler & breaks SSR.

It works with CRA because CRA *builds all dependencies*, just-in-case.

* feat(@aws-amplify/datastore): Support non-@model types in DataStore (#5128)

* Upgrade immer

* Return sooner if predicates are empty

* Fix bug when trying to delete a model instance that is not persisted

* Support non-@model types

* Generate datastore coverage report and RN integ test

* Fix tslint error

* Remove  unit test case for onGetPost

* Remove unused code

* Rename instance initializer to initializeInstance

* Rename SchemaType to SchemaNonModel

* Rename types to nonModels in schema.js

* Rename type to nonModel

* Make nonModels optional in schema.js

* Remove generic constraint from createTypeClass

* Rename ModelOrTypeConstructorMap to TypeConstructorMap

* Rename createModelAndTypeClassses to createTypeClasses

* Rename createTypeClass to createNonModelClass

* chore: remove datastore form RN integ tests (#5139)

* Fix export type of datastore storage in unit tests

* test(@aws-amplify/datastore): Fix unit tests

* [RN] Migrate zen-observable to zen-observable-ts and fix zen-push import (#5155)

* Migrate zen-observable to zen-observable-ts and fix zen-push import

* Fix unit tests

* Pin aws-sdk versions and rename presignRequest to presign (#5171)

* Migrate zen-observable to zen-observable-ts and fix zen-push import

* Fix unit tests

* Pin aws-sdk versions and rename presignRequest to presign

* Upgrade aws-sdk clients from alpha to beta (#5209)

* Migrate zen-observable to zen-observable-ts and fix zen-push import

* Fix unit tests

* Pin aws-sdk versions and rename presignRequest to presign

* Upgrade aws-sdk clients from alpha to beta

* Update expiration type to Date as per change in aws-sdk

* Fix unit tests as per expiration type change

* Fix jest failures, update snapshot

* Update storage changelog

Co-authored-by: Ashish Nanda <ashish.nanda.5591@gmail.com>
Co-authored-by: Rodriguez Elorza <elorzafe@amazon.com>
Co-authored-by: aws-amplify-bot <aws@amazon.com>
Co-authored-by: Sebastien Schwartz <schwartz.seb@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Manuel Iglesias <manuelig@amazon.com>
Co-authored-by: Ivan Artemiev <29709626+iartemiev@users.noreply.github.com>
Co-authored-by: Jens Bodal <jensbodal@gmail.com>
Co-authored-by: Ashika <35131273+ashika01@users.noreply.github.com>
Co-authored-by: Manuel Iglesias <6154160+manueliglesias@users.noreply.github.com>
Co-authored-by: Praveen Gupta <51211245+Amplifiyer@users.noreply.github.com>
Co-authored-by: Eric Clemmons <eric@smarterspam.com>
Co-authored-by: Iglesias <manuelig@3c22fb19fec4.ant.amazon.com>
Co-authored-by: Yirako <yirako@users.noreply.github.com>
Co-authored-by: pravgupt@amazon.com <pravgupt@8c85905cd208.ant.amazon.com>
@amin79
Copy link

amin79 commented Mar 25, 2021

@SebSchwartz Did you find any solution? I have the same problem.

@SebSchwartz
Copy link
Contributor Author

We don't use it anymore :p But solution should have been merged so it should work :/

@amin79
Copy link

amin79 commented Mar 25, 2021

But it does not work. Any problem I face using AWS amplify and google for it, I see the people had that problem long time ago and it's not solved yet. It seems the only project that really works perfectly with amplify is TODO project.

@github-actions
Copy link

This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DataStore Related to DataStore category to-be-reproduced Used in order for Amplify to reproduce said issue
Projects
None yet
Development

No branches or pull requests

3 participants