chore: enabling linting on __tests__ for the react-native packages (#…

…13545) * chore: enabling linting on __tests__ for the react-native packages * chore(rtn-push-notification): run yarn lint:fix * chore(rtn-push-notification): manual fix linter errors
aws-amplify · Jun 26, 2024 · b6de5f9 · b6de5f9
1 parent 2ef7c59
commit b6de5f9
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 18 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -35,25 +35,13 @@ module.exports = {
 		'setupTests.ts',
 		'jest.setup.*',
 		'jest.config.*',
-		// 'packages/adapter-nextjs/__tests__',
-		// 'packages/analytics/__tests__',
 		'packages/api/__tests__',
 		'packages/api-graphql/__tests__',
-		// 'packages/api-rest/__tests__',
-		// 'packages/auth/__tests__',
-		// 'packages/aws-amplify/__tests__',
-		// 'packages/core/__tests__',
 		'packages/datastore/__tests__',
 		'packages/datastore-storage-adapter/__tests__',
-		// 'packages/geo/__tests__',
 		'packages/interactions/__tests__',
-		// 'packages/notifications/__tests__',
 		'packages/predictions/__tests__',
 		'packages/pubsub/__tests__',
-		'packages/react-native/__tests__',
-		'packages/rtn-push-notification/__tests__',
-		'packages/rtn-web-browser/__tests__',
-		// 'packages/storage/__tests__',
 	],
 	rules: {
 		camelcase: [

diff --git a/packages/rtn-push-notification/__tests__/apis/getPermissionStatus.test.ts b/packages/rtn-push-notification/__tests__/apis/getPermissionStatus.test.ts
@@ -23,7 +23,7 @@ describe('getPermissionStatus', () => {
 	beforeAll(() => {
 		mockGetPermissionStatusNative.mockResolvedValue(status);
 		mockNormalizeNativePermissionStatus.mockImplementation(
-			status => `normalized-${status}`,
+			statusParam => `normalized-${statusParam}`,
 		);
 	});
 

diff --git a/packages/rtn-push-notification/__tests__/apis/registerHeadlessTask.test.ts b/packages/rtn-push-notification/__tests__/apis/registerHeadlessTask.test.ts
@@ -2,6 +2,7 @@
 // SPDX-License-Identifier: Apache-2.0
 
 import { AppRegistry } from 'react-native';
+
 import { getConstants } from '../../src/apis/getConstants';
 import { registerHeadlessTask } from '../../src/apis/registerHeadlessTask';
 import { normalizeNativeMessage } from '../../src/utils';

diff --git a/packages/rtn-push-notification/__tests__/testUtils/data.ts b/packages/rtn-push-notification/__tests__/testUtils/data.ts
@@ -33,7 +33,7 @@ export const fcmMessageOptions = {
 export const fcmMessagePayload = {
 	title: 'fcm-title',
 	body: 'fcm-body',
-	imageUrl: imageUrl,
+	imageUrl,
 	action: {},
 	rawData: pushNotificationAdhocData,
 };

diff --git a/packages/rtn-push-notification/__tests__/utils/normalizeNativeMessage.test.ts b/packages/rtn-push-notification/__tests__/utils/normalizeNativeMessage.test.ts
@@ -6,8 +6,8 @@ import {
 	apnsMessage,
 	apnsMessagePayload,
 	fcmMessage,
-	fcmMessagePayload,
 	fcmMessageOptions,
+	fcmMessagePayload,
 	imageUrl,
 	pushNotificationAdhocData,
 	pushNotificationDeeplinkUrl,
@@ -23,7 +23,7 @@ describe('normalizeNativeMessage', () => {
 			expect(normalizeNativeMessage(apnsMessage)).toStrictEqual({
 				title,
 				body,
-				imageUrl: imageUrl,
+				imageUrl,
 				data: {
 					...pushNotificationAdhocData,
 					'media-url': imageUrl,
@@ -72,12 +72,17 @@ describe('normalizeNativeMessage', () => {
 
 	describe('fcm messages', () => {
 		it('normalizes typical messages', () => {
-			const { body, rawData, imageUrl, title } = fcmMessagePayload;
+			const {
+				body,
+				rawData,
+				imageUrl: imageUrlFromPayload,
+				title,
+			} = fcmMessagePayload;
 
 			expect(normalizeNativeMessage(fcmMessage)).toStrictEqual({
 				body,
 				data: rawData,
-				imageUrl,
+				imageUrl: imageUrlFromPayload,
 				title,
 				fcmOptions: {
 					...fcmMessageOptions,