feat: Refresh and validate credentials after setting env var creds #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clareliguori
force-pushed
the
validate-credentials
branch
from
73c7552
to
8177395
Compare
clareliguori
changed the title
allisaurus
reviewed
Jun 3, 2020
| @@ -134,6 +152,59 @@ describe('Configure AWS Credentials', () => { | |||
| expect(core.setSecret).toHaveBeenCalledWith(FAKE_ACCOUNT_ID); | |||
| }); | |||
|
|
|||
| test('action with no accessible credentials fails', async () => { | |||
There was a problem hiding this comment.
we've got a couple tests for error cases, but is there any way to meaningfully test the positive case (correctly configuring diff creds in sequence)?
There was a problem hiding this comment.
Good point, I made this integ test that I confirmed fails prior to the change and passes after, but let me try to add a unit test too
#70
allisaurus
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57
Successful actions run:
https://github.com/clareliguori/configure-aws-credentials/runs/722182739?check_suite_focus=true
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.