Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support panel 1.0 #41

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Support panel 1.0 #41

wants to merge 12 commits into from

Conversation

MarcSkovMadsen
Copy link
Collaborator

This PR adds support for Panel 1.0

  • Fix "Warning: the global function "jsmeOnLoad" is not defined."
  • Fix Error: unknown property panel_chemistry.bokeh_extensions.jsme_editor.JSMEEditor.value
  • merge with Jhsmit:ms_viewer

FYI. @Jhsmit

@codecov
Copy link

codecov bot commented May 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (da0f009) 83.87% compared to head (25557ff) 88.42%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   83.87%   88.42%   +4.55%     
==========================================
  Files           9        9              
  Lines         186      190       +4     
==========================================
+ Hits          156      168      +12     
+ Misses         30       22       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcSkovMadsen
Copy link
Collaborator Author

When running panel serve tests/tests/test_jsme_editor.py --autoreload and opening the app I currently see 2 issues

image

I need to fix these issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants