Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust checking of age of apt cache #90

Merged
merged 1 commit into from
Feb 12, 2023

Conversation

jondo2010
Copy link
Contributor

Somehow on my CI workflows, I was not seeing any /var/cache/apt/pkgcache.bin, which apparently is the case depending on which version of Debian/Ubuntu. This was resulting in job failures.

This PR is based on an answer I found in https://askubuntu.com/questions/410247/how-to-know-last-time-apt-get-update-was-executed and should make this check more robust.

@awalsh128
Copy link
Owner

Nice find and thanks for the PR. What do you think of the other solutions in the different replies? Wondering if using apt directly to find out would avoid future behavioral changes.

@jondo2010
Copy link
Contributor Author

The other replies on the askubuntu question are variants of checking the last modified time of various files under /var/cache/apt (similar to how you originally wrote it). There doesn't seem to be any official way through the CLI tools to get this information. I think the approach in this PR is a good compromise between robustness and simplicity.

@awalsh128
Copy link
Owner

Sounds good. Merging this.

@awalsh128 awalsh128 merged commit 797d1a2 into awalsh128:master Feb 12, 2023
awalsh128 added a commit that referenced this pull request Mar 24, 2023
* More robust checking of age of apt cache (#90)

* Don't install apt-fast from source (#96)

* Clean cache directory after use (#95)

* Only install apt-fast from source if not present (#97)

* Revert "Don't install apt-fast from source (#96)"

This reverts commit 854bb53.

* Only install apt-fast from source if not present

---------

Co-authored-by: John Hughes <jondo2010@gmail.com>
Co-authored-by: Pascal Roeleven <dev@pascalroeleven.nl>
awalsh128 added a commit that referenced this pull request Mar 24, 2023
* More robust checking of age of apt cache (#90)

* Don't install apt-fast from source (#96)

* Clean cache directory after use (#95)

* Only install apt-fast from source if not present (#97)

* Revert "Don't install apt-fast from source (#96)"

This reverts commit 854bb53.

* Only install apt-fast from source if not present

---------

Co-authored-by: John Hughes <jondo2010@gmail.com>
Co-authored-by: Pascal Roeleven <dev@pascalroeleven.nl>
awalsh128 added a commit that referenced this pull request Mar 24, 2023
* More robust checking of age of apt cache (#90)

* Don't install apt-fast from source (#96)

* Clean cache directory after use (#95)

* Only install apt-fast from source if not present (#97)

* Revert "Don't install apt-fast from source (#96)"

This reverts commit 854bb53.

* Only install apt-fast from source if not present

---------

Co-authored-by: John Hughes <jondo2010@gmail.com>
Co-authored-by: Pascal Roeleven <dev@pascalroeleven.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants