-
-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add biogo #950
Add biogo #950
Conversation
@samuell hi |
golint - largely ignored (it is incorrect in a number of places and complains about generated code that is harder to read if made to conform to Go idiom - see unix philosophy axiom 16).
wiki now on - open to anyone in the first instance (I don't have time to maintain wiki pages right now). Real usage examples are in https://github.com/biogo/examples; small godoc examples exist in some packages. |
new rules 8 days with label pending-submitter-response: https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md#maintainers |
Why?
There was no request from response from @samuell and I have addressed the comments.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please look at the repo. The head package is a document comment and a version constant. The rest of the packages are tested.
|
@avelino , plz take a look |
@kortschak and about the errors on the reportcard? |
Pls fixed quality and resend PR |
Thanks. When I have time, I'll go through and good those, though I can see no good reason to apply to a club.
|
Please check if what you want to add to
awesome-go
list meets quality standards before sending pull request. Thanks!Please provide package links to:
Note, that new categories can be added only when there are 3 packages or more.
Make sure that you've checked the boxes below before you submit PR:
Thanks for your PR, you're awesome! 👍