Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add biogo #950

Closed
wants to merge 1 commit into from
Closed

Add biogo #950

wants to merge 1 commit into from

Conversation

samuell
Copy link

@samuell samuell commented May 12, 2016

Please check if what you want to add to awesome-go list meets quality standards before sending pull request. Thanks!

Please provide package links to:

Note, that new categories can be added only when there are 3 packages or more.

Make sure that you've checked the boxes below before you submit PR:

  • I have added my package in alphabetical order
  • I know that this package was not listed before
  • I have added godoc link
  • I have added gocover.io link
  • I have added goreportcard link
  • I have read Contribution guidelines and Quality standard.

Thanks for your PR, you're awesome! 👍

@kirillDanshin
Copy link
Contributor

@samuell hi
someone from biogo (@kortschak?): please fix golint, ineffassign and misspell issues from goreportcard.
As noted at biogo/biogo#2, it's a Nice, but not friendly. Wiki is turned off and I can't find any useful examples.

@kortschak
Copy link

someone from biogo (@kortschak?): please fix golint, ineffassign and misspell issues from goreportcard.

golint - largely ignored (it is incorrect in a number of places and complains about generated code that is harder to read if made to conform to Go idiom - see unix philosophy axiom 16).
ineffassign - done
mispell - done

As noted at biogo/biogo#2, it's a Nice, but not friendly. Wiki is turned off and I can't find any useful examples.

wiki now on - open to anyone in the first instance (I don't have time to maintain wiki pages right now). Real usage examples are in https://github.com/biogo/examples; small godoc examples exist in some packages.

@cassiobotaro
Copy link
Collaborator

new rules 8 days with label pending-submitter-response: https://github.com/avelino/awesome-go/blob/master/CONTRIBUTING.md#maintainers

@kortschak
Copy link

kortschak commented Jun 17, 2017 via email

@cassiobotaro cassiobotaro reopened this Jun 17, 2017
Copy link
Collaborator

@cassiobotaro cassiobotaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write tests..
image

@kortschak
Copy link

kortschak commented Jun 17, 2017 via email

@cassiobotaro
Copy link
Collaborator

@avelino , plz take a look
image

@cassiobotaro
Copy link
Collaborator

@kortschak and about the errors on the reportcard?
image
lint have a lot of warnings too
image

@avelino
Copy link
Owner

avelino commented Jun 17, 2017

Pls fixed quality and resend PR

@avelino avelino closed this Jun 17, 2017
@kortschak
Copy link

kortschak commented Jun 17, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants