caching latest version to save gas (#227)

ava-labs · Jan 9, 2024 · 9fcdf42 · 9fcdf42
1 parent 8cdfd96
commit 9fcdf42
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 12 deletions.
diff --git a/abi-bindings/go/CrossChainApplications/examples/ERC20Bridge/ERC20Bridge/ERC20Bridge.go b/abi-bindings/go/CrossChainApplications/examples/ERC20Bridge/ERC20Bridge/ERC20Bridge.go
diff --git a/...ations/examples/ExampleMessenger/ExampleCrossChainMessenger/ExampleCrossChainMessenger.go b/...ations/examples/ExampleMessenger/ExampleCrossChainMessenger/ExampleCrossChainMessenger.go
diff --git a/...go/CrossChainApplications/examples/NativeTokenBridge/ERC20TokenSource/ERC20TokenSource.go b/...go/CrossChainApplications/examples/NativeTokenBridge/ERC20TokenSource/ERC20TokenSource.go
diff --git a/...nApplications/examples/NativeTokenBridge/NativeTokenDestination/NativeTokenDestination.go b/...nApplications/examples/NativeTokenBridge/NativeTokenDestination/NativeTokenDestination.go
diff --git a/.../CrossChainApplications/examples/NativeTokenBridge/NativeTokenSource/NativeTokenSource.go b/.../CrossChainApplications/examples/NativeTokenBridge/NativeTokenSource/NativeTokenSource.go
diff --git a/...rossChainApplications/examples/VerifiedBlockHash/BlockHashPublisher/BlockHashPublisher.go b/...rossChainApplications/examples/VerifiedBlockHash/BlockHashPublisher/BlockHashPublisher.go
diff --git a/.../CrossChainApplications/examples/VerifiedBlockHash/BlockHashReceiver/BlockHashReceiver.go b/.../CrossChainApplications/examples/VerifiedBlockHash/BlockHashReceiver/BlockHashReceiver.go
diff --git a/abi-bindings/go/Teleporter/upgrades/TeleporterRegistry/TeleporterRegistry.go b/abi-bindings/go/Teleporter/upgrades/TeleporterRegistry/TeleporterRegistry.go
diff --git a/contracts/src/Teleporter/upgrades/TeleporterRegistry.sol b/contracts/src/Teleporter/upgrades/TeleporterRegistry.sol
@@ -177,8 +177,10 @@ contract TeleporterRegistry {
             "TeleporterRegistry: version already exists"
         );
         require(entry.protocolAddress != address(0), "TeleporterRegistry: zero protocol address");
+
+        uint256 latestVersion_ = latestVersion;
         require(
-            entry.version <= latestVersion + MAX_VERSION_INCREMENT,
+            entry.version <= latestVersion_ + MAX_VERSION_INCREMENT,
             "TeleporterRegistry: version increment too high"
         );
 
@@ -192,10 +194,9 @@ contract TeleporterRegistry {
         emit AddProtocolVersion(entry.version, entry.protocolAddress);
 
         // Set latest version if the version is greater than the current latest version.
-        if (entry.version > latestVersion) {
-            uint256 oldLatestVersion = latestVersion;
+        if (entry.version > latestVersion_) {
             latestVersion = entry.version;
-            emit LatestVersionUpdated(oldLatestVersion, latestVersion);
+            emit LatestVersionUpdated(latestVersion_, entry.version);
         }
     }
 }