Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate precompile tests #565
Generate precompile tests #565
Changes from 10 commits
1d0c877
bea4567
2a03da6
742d8fe
587e07a
921fd57
71cf7ae
e3b1e32
5f1067a
a029ff8
468fbda
f93be0e
b463f44
1ad8e4e
21ab80e
983f5ed
1506ebb
b81fdfb
1c498d0
d8f22bc
c9de2c4
ac3fedb
4c069cb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NewTestStateDB(t *testing.T)
does not seem correct here.Is it possible to include a test that generates a precompile then compiles or calls gofmt on the resulting code? We could do this as a separate PR or an issue, however I think it will make it easier to edit the templates in the long run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean like a unit test in the
precompile_bind_test
?