Generate precompile tests #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto config-test-suites
darioush
reviewed
Mar 7, 2023
accounts/abi/bind/precompilebind/precompile_config_test_template.go
Outdated
Show resolved
Hide resolved
| // Run tests. | ||
| for name, test := range tests { | ||
| t.Run(name, func(t *testing.T) { | ||
| test.Run(t, module, NewTestStateDB(t *testing.T)) |
There was a problem hiding this comment.
NewTestStateDB(t *testing.T) does not seem correct here.
Is it possible to include a test that generates a precompile then compiles or calls gofmt on the resulting code? We could do this as a separate PR or an issue, however I think it will make it easier to edit the templates in the long run.
There was a problem hiding this comment.
You mean like a unit test in the precompile_bind_test?
aaronbuchwald
approved these changes
Mar 8, 2023
darioush
approved these changes
Apr 28, 2023
accounts/abi/bind/precompilebind/precompile_contract_test_template.go
Outdated
Show resolved
Hide resolved
accounts/abi/bind/precompilebind/precompile_contract_test_template.go
Outdated
Show resolved
Hide resolved
accounts/abi/bind/precompilebind/precompile_contract_test_template.go
Outdated
Show resolved
Hide resolved
…late.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org>
…late.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org>
…late.go Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org>
…t-evm into generate-precompile-tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Adds unit test generation to precompile generation tool
How this works
Adds 2 new templates for contract and config tests.
How this was tested
Generated hello world precompile in #564
How is this documented
Page at https://docs.avax.network/subnets/hello-world-precompile-tutorial needs to be updated.