Use SDK Gossip #318
Merged
Use SDK Gossip #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
requested review from
aaronbuchwald,
darioush and
ceyonur
as code owners
Closed
joshua-kim
force-pushed
the
sdk-gossip-noop
branch
3 times, most recently
from
7f8afae
to
91c34d2
Compare
joshua-kim
force-pushed
the
sdk-gossip
branch
2 times, most recently
from
f427d54
to
c3271c2
Compare
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
joshua-kim
force-pushed
the
sdk-gossip
branch
from
fe12df2
to
cdb9649
Compare
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Co-authored-by: Stephen Buttolph <stephen@avalabs.org> Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
aaronbuchwald
approved these changes
Sep 12, 2023
commit 2089a73 Author: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> Date: Tue Sep 12 10:55:19 2023 -0400 nit commit 95fca6d Author: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> Date: Tue Sep 12 10:53:11 2023 -0400 nits commit 0b9deb0 Author: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> Date: Mon Sep 11 18:58:20 2023 -0400 update to avalanchego 1.10.10-rc.2
commit 0af3265 Author: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> Date: Tue Sep 12 11:25:07 2023 -0400 Update to 1.10.10-rc.2 (#328) * update to avalanchego 1.10.10-rc.2 * nits * nit commit 545b4f1 Author: Darioush Jalali <darioush.jalali@avalabs.org> Date: Mon Sep 11 09:20:23 2023 -0700 Fix TestVMShutdownWhileSyncing (#323) * Fix TestVMShutdownWhileSyncing * fix commit 347fe53 Author: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> Date: Mon Sep 11 10:53:44 2023 -0400 Fix hanging requests after Shutdown (#326) * fix requests hanging after shutdown * fix build --------- Signed-off-by: Stephen Buttolph <stephen@avalabs.org> Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
darioush
approved these changes
Sep 12, 2023
|
Separate PR to bump golangci-lint timeout from 3m to 10m here: #330 |
aaronbuchwald
approved these changes
Sep 12, 2023
StephenButtolph
approved these changes
Sep 12, 2023
Closed
darioush
pushed a commit
that referenced
this pull request
Apr 25, 2024
* Add SDK Router message handling (#316) Co-authored-by: Stephen Buttolph <stephen@avalabs.org> * Fix hanging requests after Shutdown (#326) * fix requests hanging after shutdown * fix build --------- Signed-off-by: Stephen Buttolph <stephen@avalabs.org> Co-authored-by: Stephen Buttolph <stephen@avalabs.org> * Update to 1.10.10-rc.2 (#328) * update to avalanchego 1.10.10-rc.2 * nits * nit * Add P2P SDK Pull Gossip (#318) * add batchsize * sync changes * Drop outbound gossip for non vdrs (#862) * Drop outbound gossip requests for non-validators (#334) * drop outbound gossip requests for non validators * nit * nit * sync changes --------- Co-authored-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> --------- Co-authored-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Implements gossip interfaces for
gossip.Setfor atomic and eth transactions. Adds functionality to start using the sdk's gossip implementation in the networking layer.How this works
Implements the upstream p2p interfaces for gossip
How this was tested
UTs added