Fix TestVMShutdownWhileSyncing #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
approved these changes
Sep 7, 2023
|
Fixes #257 |
aaronbuchwald
approved these changes
Sep 11, 2023
joshua-kim
added a commit
that referenced
this pull request
Sep 12, 2023
commit 0af3265 Author: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> Date: Tue Sep 12 11:25:07 2023 -0400 Update to 1.10.10-rc.2 (#328) * update to avalanchego 1.10.10-rc.2 * nits * nit commit 545b4f1 Author: Darioush Jalali <darioush.jalali@avalabs.org> Date: Mon Sep 11 09:20:23 2023 -0700 Fix TestVMShutdownWhileSyncing (#323) * Fix TestVMShutdownWhileSyncing * fix commit 347fe53 Author: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> Date: Mon Sep 11 10:53:44 2023 -0400 Fix hanging requests after Shutdown (#326) * fix requests hanging after shutdown * fix build --------- Signed-off-by: Stephen Buttolph <stephen@avalabs.org> Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
Re-opens the "chaindb" since it may be closed in the vm.Shutdown()
Alternatively we could remove the check for synced heights in case the sync errors. Either is fine by me.
How this was tested
CI, running multiple times locally