Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: hold check of plotjuggler-ros package and display warning if held #4805

Merged
merged 4 commits into from
Jun 3, 2024
Merged

chore: hold check of plotjuggler-ros package and display warning if held #4805

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15fb558
chore: Hold check of plotjuggler-ros package and display warning if held
Naophis Jun 3, 2024
fc9b58e
chore: fix condition for checking held ROS package in dev_tools role
Naophis Jun 3, 2024
ef235eb
style(pre-commit): autofix
pre-commit-ci[bot] Jun 3, 2024
dfe18f4
chore: Update dev_tools role to fix condition for checking held ROS p…
Naophis Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ansible/roles/dev_tools/tasks/main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,23 @@
state: latest
update_cache: true

- name: Hold check of ros-{{ rosdistro }}-plotjuggler-ros

Check failure on line 40 in ansible/roles/dev_tools/tasks/main.yaml

View workflow job for this annotation

GitHub Actions / pre-commit-ansible

name[template] 

Jinja templates should only be at the end of 'name'
ansible.builtin.command: apt-mark showhold
register: held_ros_packages
changed_when: false

- name: Install plotjuggler
become: true
ansible.builtin.apt:
name:
- ros-{{ rosdistro }}-plotjuggler-ros
state: latest
update_cache: true
when: "'ros-' + rosdistro + '-plotjuggler-ros' not in held_ros_packages.stdout"
register: install_result
failed_when: false

- name: Display warning if plotjuggler-ros package is held
ansible.builtin.debug:
msg: ROS package 'ros-{{ rosdistro }}-plotjuggler-ros' is apt-mark hold. Skipping installation.
when: not install_result.changed
Loading