-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docker): remove build main action #4747
Conversation
We are using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep in mind that build-main
runs every day. And docker-build-and-push-main
runs twice a month.
build-main
is necessary to keep track of the entire health of the autoware.
Also used in the README:
Lines 34 to 36 in 27e31e9
<a href="https://github.com/autowarefoundation/autoware/actions/workflows/build-main.yaml?query=branch%3Amain"> | |
<img src="https://img.shields.io/github/actions/workflow/status/autowarefoundation/autoware/build-main.yaml?style=flat&label=build-main" | |
alt="Build Main CI" /></a> |
You may remove it but you also need to provide a way to:
- Build and test entire autoware every day
- Show the status in readme file.
@oguzkaganozt I think this PR is important for the workflow refactoring, so I took over and made the necessary modifications. @xmfcx I've updated the schedule to every day and the README badge. Note that there is no |
But now the question is, do we want to update the base image and push it to registry every day? I think there was a reason to do this twice a month. @mitsudome-r @youtalk |
Oh, I finally understood. The difference between |
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Yutaka Kondo <yutaka.kondo@youtalk.jp>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
e28fed2
to
991afca
Compare
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Updated the PR so that; we are now using |
@oguzkaganozt I'm sorry to review late. Simplifying the workflow is a very good thing. This might be fixed in a future update of |
Description
To simplify CI-CD pipeline ,
build-main
andbuild-main-self-hosted
can be deleted because they are simply using the same docker build mechanism asdocker-build-main
anddocker-build-main-self-hosted
.Also renaming of:
docker-build-and-push-main
->docker-build-main
docker-build-and-push-main-self-hosted
->docker-build-main-self-hosted
can be done since docker builds does not pushes every time into the registry the naming implies false positive.
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.