Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(installation): simplify run.sh commands #551

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

oguzkaganozt
Copy link
Contributor

@oguzkaganozt oguzkaganozt commented May 16, 2024

Description

Simplify run commands for docker containers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The Reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
@oguzkaganozt oguzkaganozt self-assigned this May 16, 2024
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
@xmfcx
Copy link
Contributor

xmfcx commented May 23, 2024

@oguzkaganozt
Copy link
Contributor Author

From here:

image
@oguzkaganozt I was looking into https://autowarefoundation.github.io/autoware-documentation/main/installation/autoware/docker-installation/#prerequisites and noticed the setup-dev-env.sh doesn't have any "docker" references, so is this documentation wrong or outdated?

@xmfcx Here is the setting of target playbook which sets it as docker when you call setup_dev_env.sh docker

@xmfcx xmfcx added the tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) label May 30, 2024
Copy link

stale bot commented Jul 29, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label Jul 29, 2024
@oguzkaganozt oguzkaganozt removed the status:stale Inactive or outdated issues. (auto-assigned) label Aug 1, 2024
@oguzkaganozt oguzkaganozt requested a review from xmfcx August 1, 2024 12:08
@oguzkaganozt
Copy link
Contributor Author

@youtalk @xmfcx

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oguzkaganozt oguzkaganozt merged commit e610261 into main Aug 1, 2024
9 checks passed
@oguzkaganozt oguzkaganozt deleted the add-modular-containers branch August 1, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants