Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update code for latest scipy and sphinx-gallery #1551

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

mfeurer
Copy link
Contributor

@mfeurer mfeurer commented Aug 3, 2022

@mfeurer mfeurer changed the title Make meta-feature computation compatible with scipy 1.9 Update code for latest scipy and sphinx-gallery Aug 3, 2022
@codecov
Copy link

codecov bot commented Aug 3, 2022

Codecov Report

Merging #1551 (bf13aa4) into development (af9d469) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development    #1551      +/-   ##
===============================================
- Coverage        84.38%   84.22%   -0.17%     
===============================================
  Files              154      154              
  Lines            11694    11702       +8     
  Branches          2038     2042       +4     
===============================================
- Hits              9868     9856      -12     
- Misses            1282     1298      +16     
- Partials           544      548       +4     

Impacted file tree graph

Copy link
Contributor

@eddiebergman eddiebergman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it was a cumbersome PR but delighted to see the whole array of green ticks! LGTM! 🥳

@mfeurer mfeurer merged commit 3b3e694 into development Aug 4, 2022
@mfeurer mfeurer deleted the make_scipy1_9_0_compatible branch August 4, 2022 09:02
eddiebergman pushed a commit that referenced this pull request Aug 18, 2022
* Make meta-feature computation compatible with scipy 1.9

* Also fix doc for latest sphinx-gallery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants