Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user_id_attribute support to AzureAD connection options #1028

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

acwest
Copy link
Contributor

@acwest acwest commented Sep 19, 2024

🔧 Changes

Add Support for user_id_attribute to auth0_connection options attribute for AzureAD connections (strategy="waad")

📚 References

Issue: #1006

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (efdad32) to head (d112601).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1028   +/-   ##
=======================================
  Coverage   90.25%   90.25%           
=======================================
  Files         112      112           
  Lines       16348    16350    +2     
=======================================
+ Hits        14755    14757    +2     
  Misses       1118     1118           
  Partials      475      475           
Files with missing lines Coverage Δ
internal/auth0/connection/expand.go 93.27% <100.00%> (+<0.01%) ⬆️
internal/auth0/connection/flatten.go 80.56% <100.00%> (+0.02%) ⬆️

@acwest acwest force-pushed the ESD-40358-add-user-id-attribute-to-azureAD branch from 0874dde to d112601 Compare September 20, 2024 13:38
@acwest acwest marked this pull request as ready for review September 20, 2024 13:40
@acwest acwest requested a review from a team as a code owner September 20, 2024 13:40
@acwest acwest merged commit 5e982d1 into main Sep 23, 2024
9 checks passed
@acwest acwest deleted the ESD-40358-add-user-id-attribute-to-azureAD branch September 23, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants