Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch: Client default_organization import issue on terraform generate #1021

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

duedares-rvj
Copy link
Contributor

@duedares-rvj duedares-rvj commented Sep 10, 2024

🔧 Changes

  1. Updated the default_organization schema by relaxing the ConflictsWith and RequiredWith parameters, allowing constraints to be handled independently.
  2. Replaced the usage of a nullable struct with an additional API call to set default_organization to nil.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@duedares-rvj duedares-rvj self-assigned this Sep 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 92.10526% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.25%. Comparing base (3b87a8f) to head (3d2599f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/auth0/client/resource.go 85.71% 2 Missing and 2 partials ⚠️
internal/auth0/client/expand.go 95.83% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1021      +/-   ##
==========================================
+ Coverage   90.14%   90.25%   +0.10%     
==========================================
  Files         112      112              
  Lines       15092    15104      +12     
==========================================
+ Hits        13605    13632      +27     
+ Misses       1050     1040      -10     
+ Partials      437      432       -5     
Files with missing lines Coverage Δ
internal/auth0/client/expand.go 96.40% <95.83%> (+1.38%) ⬆️
internal/auth0/client/resource.go 98.43% <85.71%> (+0.86%) ⬆️

... and 1 file with indirect coverage changes

@duedares-rvj duedares-rvj marked this pull request as ready for review September 10, 2024 16:54
@duedares-rvj duedares-rvj requested a review from a team as a code owner September 10, 2024 16:54
acwest
acwest previously approved these changes Sep 10, 2024
Copy link
Contributor

@developerkunal developerkunal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@duedares-rvj duedares-rvj merged commit c2d1a1d into main Sep 11, 2024
9 checks passed
@duedares-rvj duedares-rvj deleted the PATCH/Client-Creds branch September 11, 2024 08:25
@duedares-rvj duedares-rvj changed the title Patch: default_organization on Client Creds Patch: Client-Creds default_organization import issue on terraform generate Sep 11, 2024
@duedares-rvj duedares-rvj changed the title Patch: Client-Creds default_organization import issue on terraform generate Patch: default_organization import issue on terraform generate Sep 11, 2024
@duedares-rvj duedares-rvj changed the title Patch: default_organization import issue on terraform generate Patch: Client default_organization import issue on terraform generate Sep 11, 2024
@developerkunal developerkunal changed the title Patch: Client default_organization import issue on terraform generate Patch: Client default_organization import issue on terraform generate Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants