Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destroy the request when reaches the timeout (#270) #271

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Destroy the request when reaches the timeout (#270) #271

merged 1 commit into from
Oct 12, 2021

Conversation

amrsalama
Copy link
Contributor

@amrsalama amrsalama commented Oct 11, 2021 •
edited

Description

This is a fix to the timeout issue described in #270

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@amrsalama amrsalama requested a review from a team as a code owner October 11, 2021 21:25
adamjmcgrath
adamjmcgrath approved these changes Oct 12, 2021
View reviewed changes
Copy link
Contributor

@adamjmcgrath adamjmcgrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amrsalama

@adamjmcgrath adamjmcgrath merged commit fb0ded0 into auth0:master Oct 12, 2021
@adamjmcgrath adamjmcgrath mentioned this pull request Oct 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamjmcgrath adamjmcgrath adamjmcgrath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amrsalama @adamjmcgrath