Integrate with passport-jwt

[gconnolly]

I created an integration with passport/passport-jwt, so I thought I would share it. It includes the integration as well as an example.

[sandrinodimattia]

Thanks for the PR. Can you add some tests?

[gconnolly]

@sandrinodimattia tests added. Getting the error messages to bubble up to validate expectations is a little strange with passport + express, but it gets the job done.

[gconnolly]

@sandrinodimattia is there anything I can do to move this towards a merge?

[rassokhin-s]

Hey guys, are there any plans to merge this PR?

[gconnolly]

I sort of feel like maybe I shouldn't have spent my time to write the tests?

[xmlking]

@gconnolly thanks for your contribution. I am planing to use your PR along with @nestjs/passport
do you have your version on NPM ?

[tdespenza]

"So when is this getting merged?"

[xmlking]

@gconnolly I send you PR with latest upstream merged. Also now exposing function passportJwtSecret(options: JwksRsa.Options): ExpressJwt.SecretCallback; in index.d.ts for easy import.

[SeanLMcCullough]

Almost a year later and still waiting...

[gconnolly]

@xmlking Somehow I missed the notification of your PR 🤷‍♂️ . Merged! thank you.

I noticed several version changes to the package.json. I am having difficulty tracing them back to the corresponding upstream commit, and they are not currently in master.

CC @SeanLMcCullough thanks for the ping. Hopefully we get a merge before its first birthday 🍰

[kevinranks]

Any plans on merging this? What's the hold up? Anything I can do to help?

[gconnolly]

reverted some unintentional dependency changes. Will continue to maintain this PR, while there are still people inquiring about it.

[EtienneK]

Please merge this. I really need this.

[garyevari]

This has been waiting for over a year... any chance this is going to happen?

[kevinranks]

Please merge!

[taurenk]

@gconnolly any plans to merge this soon?

[cspicuzza]

please merge 🙏

[sonman1]

This worked well for me. Thanks for the work on the PR! Looking forward to seeing it merged.

[jajaperson]

@sandrinodimattia Plz merge.

[jajaperson]

If anyone wants to use this NOW, I've made a fork of this fork (jajaperson/node-rwks-rsa) with the prePublish script switched to a prepare script, so you can install it via npm install jajaperson/node-rwks-rsa or npm install github:jajaperson/node-rwks-rsa.

[svantetobias]

This would be really useful. Waiting for it.

[gperdomor]

please merge this

[maciejmatu]

@Mutmatt @sandrinodimattia @lbalmaceda @gconnolly Not sure who is the owner/maintainer of this repo, but is there any work to be done on this ticket, and who could merge it when it's finished. If there are some updates needed I can spare some time to work on it, as it would be nicer to stay with the official package, without using forked repos 😄

[murbanowicz]

@lbalmaceda @damieng @Mutmatt @cocojoe @sandrinodimattia Could you or any of your colleagues finally merge this?

[blakedietz]

What's going on with this ticket? Someone? Anyone? Hellooooo?

What are the next steps to make this bad boy merge?

[O-Mutt]

Oye! I can check on this on Monday. Not trying to pass the buck, however, this repo isn't owned or maintained by my team. We just used it. I'll see if I can get the group some traction

[jajaperson]

@Mutmatt any progress?

[O-Mutt]

We are actively discussing this PR internally and certainly value the effort, time, and energy everyone has contributed here. I don’t yet have an update to report but will provide one when I am able to.

[lbalmaceda]

Thanks for the follow up @Mutmatt. Someone from our side has reviewed the PR. I'll proceed to merge this and make a new release.

[gconnolly]

😎