Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2626] getKeysInterceptor types #251

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Conversation

davidpatrick
Copy link
Contributor

getKeysInterceptor keys supplied are not quite not known yet, alg+kid should be specified, but further strictness is not needed

Closes #246

getKeysInterceptor keys supplied are not quite not known yet, alg+kid should be specified, but further strictness is not needed
@davidpatrick davidpatrick requested a review from a team as a code owner June 25, 2021 21:56
@adamjmcgrath
Copy link
Contributor

lgtm, although I would just call the UnknownKey a JWK since that's what it is - keys is the raw JWK Set you get from https://brucke.auth0.com/.well-known/jwks.json before it gets processed by https://github.com/auth0/node-jwks-rsa/blob/master/src/utils.js#L3

This is how jose defines a JWKS - although I think your definition is fine for our purposes

@adamjmcgrath adamjmcgrath merged commit bd315cf into master Jul 15, 2021
@adamjmcgrath adamjmcgrath added this to the vNext milestone Jul 16, 2021
@adamjmcgrath adamjmcgrath mentioned this pull request Jul 16, 2021
@evansims evansims deleted the typefix-getKeysInterceptor branch July 5, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getKeysInterceptor in typescript is not working.
2 participants