Use axios url parameter instead of baseURL #153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the axios request parameters to use
url
instead ofbaseURL
.baseURL
should only be used in combination withurl
, otherwise it should only beurl
.This caused an error for me when working with Axios Mock Adapter since it expected a
url
to exist. I've created a PR for that particular library, but this might cause issues elsewhere.References
Testing
The existing tests already cover this
Checklist
master