Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use axios url parameter instead of baseURL #153

Merged
merged 2 commits into from
Aug 12, 2020

Conversation

novascreen
Copy link
Contributor

@novascreen novascreen commented Jul 24, 2020

Description

This changes the axios request parameters to use url instead of baseURL. baseURL should only be used in combination with url, otherwise it should only be url.

This caused an error for me when working with Axios Mock Adapter since it expected a url to exist. I've created a PR for that particular library, but this might cause issues elsewhere.

References

Testing

The existing tests already cover this

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@novascreen novascreen marked this pull request as ready for review July 24, 2020 15:11
@novascreen novascreen requested a review from a team July 24, 2020 15:11
@jimmyjames jimmyjames self-requested a review August 12, 2020 15:52
@jimmyjames jimmyjames added this to the v1-Next milestone Aug 12, 2020
Copy link
Contributor

@jimmyjames jimmyjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants