Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Linter step to CI #129

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Add Linter step to CI #129

merged 1 commit into from
Feb 18, 2020

Conversation

davidpatrick
Copy link
Contributor

@davidpatrick davidpatrick commented Feb 18, 2020 •
edited

Description

This PR fixes linting issues with this library

  • Fixes linting issues (no other code changes)
  • Upgrades babel-eslint 8.x(anything above adds a node8+ requirement, and we havent pinned a node version yet)
  • Adds lint script to run on CI

@davidpatrick davidpatrick requested a review from a team February 18, 2020 17:17
@lbalmaceda
Copy link
Contributor

lbalmaceda commented Feb 18, 2020 •
edited

Adds lint script to run on CI

@davidpatrick you forgot that change? I don't see the config file is changed. Please, add it as a separate step that runs prior to the tests. This way, we can easily check which step failed (lint vs tests)

lbalmaceda
lbalmaceda approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidpatrick davidpatrick merged commit d0c5787 into master Feb 18, 2020
@lbalmaceda lbalmaceda changed the title Fix Linting Add Linter step to CI Feb 18, 2020
@lbalmaceda lbalmaceda deleted the fix-linter-issues branch February 18, 2020 18:15
@davidpatrick davidpatrick added this to the 1.7.0 milestone Feb 18, 2020
@davidpatrick davidpatrick mentioned this pull request Feb 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
CH: Fixed
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidpatrick @lbalmaceda