[SDK-1221] Modify Cache Defaults #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpatrick
force-pushed
the
cacheChanges
branch
2 times, most recently
from
cf941c9
to
88f7295
Compare
davidpatrick
commented
Feb 4, 2020
| @@ -14,6 +14,7 @@ describe('JwksClient (cache)', () => { | |||
| describe('#getSigningKeys', () => { | |||
| it('should prevent too many requests', (done) => { | |||
| const client = new JwksClient({ | |||
| cache: false, | |||
There was a problem hiding this comment.
Previously the cache was off by default for this test, turning off the cache to not change functionality in this test
davidpatrick
force-pushed
the
cacheChanges
branch
from
88f7295
to
f1a6324
Compare
jimmyjames
requested changes
Feb 4, 2020
README.md
Outdated
| @@ -39,15 +39,15 @@ Integrations are also provided with: | |||
|
|
|||
| ### Caching | |||
|
|
|||
| In order to prevent a call to be made each time a signing key needs to be retrieved you can also configure a cache as follows. If a signing key matching the `kid` is found, this will be cached and the next time this `kid` is requested the signing key will be served from the cache instead of calling back to the JWKS endpoint. | |||
| In order to prevent a call to be made each time a signing key needs to be retrieved a cache is implemented. If a signing key matching the `kid` is found, this will be cached and the next time this `kid` is requested the signing key will be served from the cache instead of calling back to the JWKS endpoint. | |||
There was a problem hiding this comment.
The first sentence reads a bit awkwardly. Perhaps something like By default, signing keys are cached to prevent....
davidpatrick
force-pushed
the
cacheChanges
branch
from
f1a6324
to
f1d408c
Compare
- enables cache by default (previously not) - changes cache time from 10h to 10m - updated tests to reflect the intent of the cache
davidpatrick
force-pushed
the
cacheChanges
branch
from
f1d408c
to
17e83df
Compare
jimmyjames
approved these changes
Feb 4, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to allow for better expiration of keys after a signing key rotation the following changes have been made to the cache:
Testing
Updated the tests to more properly reflect the caching mechanism.
Checklist
master