Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Apple's nonce_supported claim #841

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dspinellis
Copy link

Description

Apple's authentication identity token can contain a non-standard nonce_supported claim.
As specified, by Apple when this claim is set to false the nonce check shall be skipped.

https://developer.apple.com/documentation/sign_in_with_apple/sign_in_with_apple_rest_api/authenticating_users_with_sign_in_with_apple

Testing

The unit test option-nonce-supported.test.js covers all four cases of the changed conditional.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

Apple's authentication identity token can contain a non-standard
nonce_supported claim.  As specified, when this is set to false
skip the nonce check.

https://developer.apple.com/documentation/sign_in_with_apple/sign_in_with_apple_rest_api/authenticating_users_with_sign_in_with_apple
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant