DXCDT-547: Add websocket connection and send data on connect #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Widcket
reviewed
Oct 5, 2023
Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/auth0-universal-login-customize #863 +/- ##
==========================================================================
Coverage ? 73.26%
==========================================================================
Files ? 93
Lines ? 12138
Branches ? 0
==========================================================================
Hits ? 8893
Misses ? 2726
Partials ? 519 ☔ View full report in Codecov by Sentry. |
Widcket
approved these changes
Oct 6, 2023
willvedd
approved these changes
Oct 6, 2023
sergiught
merged commit 8f5a0cc
into
feature/auth0-universal-login-customize
8 checks passed
sergiught
added a commit
that referenced
this pull request
Nov 1, 2023
Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
This PR adds the websocket connection and sends the branding data on connect. The code is only partially tested. More e2e testing will follow at a later point in time.
📚 References
🔬 Testing
📝 Checklist