Skip to content

Commit

Permalink
Remove usernameOnlyPlaceholder from default custom text translations (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
sergiught committed Nov 1, 2023
1 parent 858858a commit effa673
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion internal/cli/prompts_custom_text.go
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ func mergeBrandingTextTranslations(
}

for key, text := range translations {
if strings.HasPrefix(key, "error") || strings.HasPrefix(key, "devKeys") {
if strings.HasPrefix(key, "error") || strings.HasPrefix(key, "devKeys") || key == "usernameOnlyPlaceholder" {
continue
}

Expand Down
4 changes: 0 additions & 4 deletions internal/cli/universal_login_customize_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,6 @@ func TestFetchUniversalLoginBrandingData(t *testing.T) {
"signupActionText": "${footerText}",
"title": "Welcome friend, glad to have you!",
"user-blocked": "Your account has been blocked after multiple consecutive login attempts.",
"usernameOnlyPlaceholder": "Username",
"usernamePlaceholder": "Username or email address",
"wrong-credentials": "Wrong username or password",
"wrong-email-credentials": "Wrong email or password",
Expand Down Expand Up @@ -358,7 +357,6 @@ func TestFetchUniversalLoginBrandingData(t *testing.T) {
"signupActionText": "${footerText}",
"title": "Welcome friend, glad to have you!",
"user-blocked": "Your account has been blocked after multiple consecutive login attempts.",
"usernameOnlyPlaceholder": "Username",
"usernamePlaceholder": "Username or email address",
"wrong-credentials": "Wrong username or password",
"wrong-email-credentials": "Wrong email or password",
Expand Down Expand Up @@ -485,7 +483,6 @@ func TestFetchUniversalLoginBrandingData(t *testing.T) {
"signupActionText": "${footerText}",
"title": "Welcome friend, glad to have you!",
"user-blocked": "Your account has been blocked after multiple consecutive login attempts.",
"usernameOnlyPlaceholder": "Username",
"usernamePlaceholder": "Username or email address",
"wrong-credentials": "Wrong username or password",
"wrong-email-credentials": "Wrong email or password",
Expand Down Expand Up @@ -692,7 +689,6 @@ func TestFetchUniversalLoginBrandingData(t *testing.T) {
"signupActionText": "${footerText}",
"title": "Welcome friend, glad to have you!",
"user-blocked": "Your account has been blocked after multiple consecutive login attempts.",
"usernameOnlyPlaceholder": "Username",
"usernamePlaceholder": "Username or email address",
"wrong-credentials": "Wrong username or password",
"wrong-email-credentials": "Wrong email or password",
Expand Down

0 comments on commit effa673

Please sign in to comment.