Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Add border around avatar to identify their cursor color #365

Merged
merged 8 commits into from
Apr 18, 2018

Conversation

jasonrudolph
Copy link
Contributor

@jasonrudolph jasonrudolph commented Apr 17, 2018

Closes #338

Depends on atom/teletype-client#61


Description of the Change

This pull request implements the design shown in #338 (comment).

In the screenshot below, we see the addition of colored borders around some avatars. When a participant's cursor appears in the current editor, the avatar will now have a border with a color that matches the user's cursor color.

screenshot

Verification Process

  • Border shown when another collaborator is typing in the same editor
  • Border not shown when another collaborator is typing in a different editor
  • Border appears again when collaborator navigates to the editor you're currently viewing and begins typing or selecting
  • Border not shown when another collaborator is viewing a non-portal item (e.g., the settings view)
  • Border not shown when another collaborator has a retracted tether
  • Up to 15 sites can have unique cursor colors

TODO

Whenever Teletype is displaying a cursor for a remote participant,
enhance the SitePositionsComponent to show a corresponding border around
that site's avatar, with the border color matching the site's cursor
color.
@jasonrudolph
Copy link
Contributor Author

@simurai: I took a first pass at the CSS for this pull request, but I'd love to get your eyes on it. Would you mind taking a look to see if there's anything we should change? Feel free to push any recommended changes to this branch.

One thing in particular that I'd like help with is the way the link icon is rendered in relation to the border. It's difficult to explain in words, but hopefully the screenshot below gives you an idea of the issue:

screen_shot_2018-04-17_at_18_57_34_pm

Is there a way that we can improve that?

To make it look better with a site border
@simurai
Copy link
Contributor

simurai commented Apr 18, 2018

the way the link icon is rendered in relation to the border.

Moved the icon a bit to better cover the site border:

image

@jasonrudolph
Copy link
Contributor Author

Thanks for those updates, @simurai. They look great! ⚡

@jasonrudolph
Copy link
Contributor Author

Some light stress testing...

screenshot

@jasonrudolph jasonrudolph merged commit e3daae7 into master Apr 18, 2018
@jasonrudolph jasonrudolph deleted the use-cursor-color-for-avatar-borders branch April 18, 2018 18:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants