This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Allow guests to use fuzzy-finder to open any remote editor shared by the host #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new method will later be exposed as a service so that clients like fuzzy-finder can use the data stored in a teletype session. Signed-off-by: Jason Rudolph <jasonrudolph@github.com>
Signed-off-by: Jason Rudolph <jasonrudolph@github.com>
Signed-off-by: Jason Rudolph <jasonrudolph@github.com>
Signed-off-by: Jason Rudolph <jasonrudolph@github.com>
Signed-off-by: Jason Rudolph <jasonrudolph@github.com>
Co-authored-by: Antonio Scandurra <as-cii@github.com>
We can only open local editors for which a remote editor already exists, so it makes sense to expose editors instead of remote buffers. In the future we may want to decouple remote editors from local editors (e.g. if we want to allow opening arbitrary files that aren't necessarily in the host's workspace), but we will probably expose a different API for that when that time comes.
Co-authored-by: Jason Rudolph <jason@jasonrudolph.com>
Co-authored-by: Jason Rudolph <jason@jasonrudolph.com>
Previously we used to show the empty portal pane item to indicate when the leader was doing something else. Now that guests can switch to an arbitrary open buffer on the host, this behavior adds extra complexity without providing the same value as before.
Guests can use the fuzzy-finder to browse to open buffers on the host.
Also, exercise `getRemoteEditors` via an integration test to ensure we interact with teletype-client correctly. Co-authored-by: Jason Rudolph <jason@jasonrudolph.com>
Co-authored-by: Jason Rudolph <jason@jasonrudolph.com>
Co-authored-by: Jason Rudolph <jason@jasonrudolph.com>
Co-authored-by: Jason Rudolph <jason@jasonrudolph.com>
Co-authored-by: Jason Rudolph <jason@jasonrudolph.com>
Co-authored-by: Jason Rudolph <jason@jasonrudolph.com>
7 tasks
3 tasks
Instead of using `removeEditorProxy` to understand whether an editor was removed manually or not from a guest portal, we are moving the code that manages the destruction of an editor from EditorBinding to GuestPortalBinding. This allows to understand the order in which the editor and the editor proxy destruction events occur. If the former occurs before the latter, it means that the user has manually destroyed the editor. If the events occur in the opposite order, it means that the host has destroyed the editor. These events are then used to determine whether the tether should be detached after the active pane item changes. This refactoring will pave the way to remove `addEditorProxy` and `removeEditorProxy`.
added 8 commits
February 14, 2018 12:00
10 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on atom/teletype-client#52
Description of the Change
In conjunction with atom/teletype-client#52 and atom/fuzzy-finder#335, this pull request implements the necessary atom/teletype changes to deliver the following functionality for #268:
Notable details
lib/teletype-service.js.) The fuzzy-finder package will consume this service.Verification Process
apm linkit.apm linkit.cmd+b, to show all the buffers you've opened locally (including the remote ones).cmd+t, to show all local files as well as all the tabs that are currently open on the host.Bonus feature: now
Pane: Reopen Closed Itemworks with remote tabs too!TODO
TODOcomments in the diffteletypethe name we want to use for the service? Should it instead beremote-editors,remote-buffers,collaboration, …?🍐'ed with @as-cii