Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: persist filters as URL query params on Tools page #1497

Merged

Conversation

Olaleye-Blessing
Copy link
Contributor

@Olaleye-Blessing Olaleye-Blessing commented Apr 5, 2023

Description
Users lose the filter options whenever they refresh the tools page. This is because the options are being saved in states.
With this PR, users can now refresh the page and still have their filter options available.

Related issue(s)

Closes: #1312

@netlify
Copy link

netlify bot commented Apr 5, 2023

Deploy Preview for asyncapi-website ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit afeb8cb
🔍 Latest deploy log https://app.netlify.com/sites/asyncapi-website/deploys/6437d14615731e0008d0442d
😎 Deploy Preview https://deploy-preview-1497--asyncapi-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 28
🟠 Accessibility 88
🟢 Best practices 92
🟢 SEO 100
🔴 PWA 30

Lighthouse ran on https://deploy-preview-1497--asyncapi-website.netlify.app/

Copy link
Member

@akshatnema akshatnema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Olaleye-Blessing thanks for creating PR for the issue. Here are certain issues you have to resolve:

image

These subheadings shouldn't get centered. Kindly make them left aligned with the block.

@Olaleye-Blessing
Copy link
Contributor Author

Hey @Olaleye-Blessing thanks for creating PR for the issue. Here are certain issues you have to resolve:

image

These subheadings shouldn't get centered. Kindly make them left aligned with the block.

I don't know how this happened since I didn't touch the styling.
It has been fixed.

@akshatnema
Copy link
Member

/rtm

@asyncapi-bot asyncapi-bot merged commit 88f5f91 into asyncapi:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persist filters in Tools view in the URL as query parameters
3 participants