feat: add reply object and reply address object #330
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| { | ||
| "type": "object", | ||
| "additionalProperties": false, | ||
| "patternProperties": { | ||
| "^x-[\\w\\d\\.\\x2d_]+$": { | ||
| "$ref": "http://asyncapi.com/definitions/3.0.0/specificationExtension.json" | ||
| } | ||
| }, | ||
| "properties": { | ||
| "address": { | ||
| "oneOf": [ | ||
| { | ||
| "$ref": "http://asyncapi.com/definitions/3.0.0/Reference.json" | ||
| }, | ||
| { | ||
| "$ref": "http://asyncapi.com/definitions/3.0.0/operationReplyAddress.json" | ||
| } | ||
| ] | ||
| }, | ||
| "channel": { | ||
|
There was a problem hiding this comment. @magicmatatjahu messages field is missing. See https://github.com/asyncapi/spec/blob/next-major-spec/spec/asyncapi.md#operation-reply-object There was a problem hiding this comment. Field was created before my PR. I will add that. There was a problem hiding this comment. @smoya Added :) Can you accept? |
||
| "$ref": "http://asyncapi.com/definitions/3.0.0/Reference.json" | ||
| } | ||
| }, | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "$id": "http://asyncapi.com/definitions/3.0.0/operationReply.json" | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "type": "object", | ||
| "additionalProperties": false, | ||
| "patternProperties": { | ||
| "^x-[\\w\\d\\.\\x2d_]+$": { | ||
| "$ref": "http://asyncapi.com/definitions/3.0.0/specificationExtension.json" | ||
| } | ||
| }, | ||
| "required": [ | ||
| "location" | ||
| ], | ||
| "properties": { | ||
| "location": { | ||
| "type": "string", | ||
| "description": "A runtime expression that specifies the location of the reply address.", | ||
| "pattern": "^\\$message\\.(header|payload)#(\\/(([^\\/~])|(~[01]))*)*" | ||
| }, | ||
| "description": { | ||
| "type": "string", | ||
| "description": "An optional description of the address. CommonMark is allowed." | ||
| } | ||
| }, | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "$id": "http://asyncapi.com/definitions/3.0.0/operationReplyAddress.json" | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you removing the
serverBindings? 🤔There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL, good catch! 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed! Thanks!