-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update @asyncapi/specs to 4.2.0 version #730
Conversation
We do explicit validation of payloads, but now they are starting to be validated by our JSON Schema files, so we can start to phase them out. Thats why the tests fails because it expects our own validators to throw the error, now the core validation step. |
@jonaslagoni but if we change the error type that we throw, it is a breaking change |
Yea was going to ask that next 😆 Now sure which approach to take to update the dependency. |
well, parser needs new major, of course we can just resign from bumping to latest specs package in master, and do bump only in 2.0 release candidate IMHO 2.0-only is best approach. Especially that it is already integrated in some tools I think. @fmvilas @magicmatatjahu @smoya share your thoughts please |
@fmvilas @magicmatatjahu @smoya share your thoughts please |
Merging this in Additionally, to create a new PR freezing EDIT: Issue created #736 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
target next-major
branch
Yeah, I think it’s a breaking change too. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@smoya we're closing this one, right? you freezed the version? |
No description provided.