Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add .asyncapi-tool file #342

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

TheEques
Copy link
Contributor

Added .asyncapi-tool file
Adds new template to tools dashboard under AsyncAPI generator templates category

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@TheEques
Copy link
Contributor Author

Hey @derberg, can you take a look at this
Let me know if any changes are required
I am working on adding more templates

.asyncapi-tool Outdated Show resolved Hide resolved
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
@TheEques TheEques requested a review from derberg October 12, 2023 14:30
@TheEques
Copy link
Contributor Author

@derberg is it correct?
Also I have made a few more PRs for other templates

.asyncapi-tool Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@Tenischev Tenischev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not code owner but lgfm

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MichaelDavisSolace @CameronRushton please approve and merge

Copy link
Member

@CameronRushton CameronRushton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@CameronRushton
Copy link
Member

I see the test are failing for an unrelated reason. I'll take a look and merge this for you when it's fixed.

@derberg
Copy link
Member

derberg commented Nov 7, 2023

Tests fail because of CI incompatibility. This needs to be addressed #335

Copy link

sonarcloud bot commented Aug 13, 2024

@CameronRushton CameronRushton merged commit aea1475 into asyncapi:master Aug 13, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants