Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve the template tutorial's readability #1154

Merged
merged 7 commits into from
Apr 9, 2024

Conversation

lmgyuan
Copy link
Collaborator

@lmgyuan lmgyuan commented Mar 28, 2024

Description

This PR is to make the tutorial documentation clearer for users to understand, as requested by @derberg : )

  • Update the Overview of Steps to make it easier for users to understand what the project directory should look like.
  • Add directory information so users know where to use what commands more clearly.
  • Make the part that creates client.py clearer about where and how to use the commands.
  • Add a detailed path for the directory of the TopicFunction.js file.
  • Add three project directory graphs so users can have a visual understanding of the project structure.

Related issue(s)
See also #1145

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@lmgyuan lmgyuan changed the title docs: Improve the template tutorial's readability docs: improve the template tutorial's readability Mar 28, 2024
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, tutorial got more explicit, I especially like the approach with showing directory structure

there are 2 comments @lmgyuan you need to address

docs/generator-template.md Outdated Show resolved Hide resolved
5. Create a new file named **index.js** in your **template** directory. This file is used to define the **logic** for your template.
6. Create a **test.py** file to validate the logic of your application.
3. Create a new folder **test/fixtures** with a file named **asyncapi.yml** in your fixtures directory. This file is used to define the **structure** of your template. You can copy the above template and paste it in your **asyncapi.yml** file.
4. Create a new file named **package.json** in your **python-mqtt-client-template** directory. This file is used to define the **dependencies** for your template.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, good 👁️

Now your directory should look like this:

```
python-mqtt-client-template
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼

docs/generator-template.md Outdated Show resolved Hide resolved
lmgyuan and others added 2 commits April 3, 2024 10:43
Copy link

sonarcloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@derberg
Copy link
Member

derberg commented Apr 9, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit e256ed9 into asyncapi:master Apr 9, 2024
14 checks passed
@derberg
Copy link
Member

derberg commented Apr 9, 2024

@allcontributors please add @lmgyuan for docs

Copy link
Contributor

@derberg

I've put up a pull request to add @lmgyuan! 🎉

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.17.21 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants