fix: improved card readability #293
Conversation
TenzDelek
requested review from
AceTheCreator,
thulieblack and
Mayaleeeee
as code owners
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TenzDelek
changed the title
components/Venue/venue.js
Outdated
| <div className='flex justify-between items-center'> | ||
| <div><div className={`border text-white text-md rounded-lg p-1 text-center mt-2 ${city.cfp ? 'block': 'hidden' }`}>cfp is open</div></div> | ||
| <div><div className={` text-md text-white text-md rounded-xl px-2 py-1 bg-[#3e4757] text-sm text-center mt-2 ${city.cfp ? 'block': 'hidden' }`}>cfp is open</div></div> |
There was a problem hiding this comment.
You are using multiple overriding text sizes. Also, try to make it pixel perfect including the cfp is open shadow and border radius as in figma file
can you share the use of lucide-react.
There was a problem hiding this comment.
@akkshitgupta oh , i will fix that right away, and for the lucide-react, i dont know how it is install in that package, i will remove that .
There was a problem hiding this comment.
done with the changes, and for the lucide-react, when i try to remove that, the build was failing, i think that the library is used in some other component, so for my guess, back then when i forked the main branch and run the installation, the version of that might have been change, thats why it was reflecting in my pr changes.
components/Venue/venue.js
Outdated
| <div className='flex justify-between items-center'> | ||
| <div><div className={`border text-white text-md rounded-lg p-1 text-center mt-2 ${city.cfp ? 'block': 'hidden' }`}>cfp is open</div></div> | ||
| <div><div className={` text-md text-white text-md rounded-xl px-2 py-1 bg-[#3e4757] text-sm text-center mt-2 ${city.cfp ? 'block': 'hidden' }`}>cfp is open</div></div> |
There was a problem hiding this comment.
@akkshitgupta oh , i will fix that right away, and for the lucide-react, i dont know how it is install in that package, i will remove that .
|
@TenzDelek I would not prefer to include the |
|
@akkshitgupta got it, will try to see whether the build is happening with that version |
|
@TenzDelek, there's a PR doing the same thing as yours, so I'm going to close this. Thanks for picking it up tho 🙏🏾 |
|
@AceTheCreator Ah, no problem it was a great first experience doing PR request |
fixes #266
Description
made the card text readable