Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added a gallery #291

Closed
wants to merge 3 commits into from
Closed

Conversation

Kavisha4
Copy link

@Kavisha4 Kavisha4 commented Mar 25, 2024

Description
Added a gallery on the Home page, used masonry pictures, carousel

Related issue(s)
Related issue #264

Gallery added
image

Copy link

netlify bot commented Mar 25, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit 840508b
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/660435efc54abd0008bcf73d
😎 Deploy Preview https://deploy-preview-291--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Kavisha4 Kavisha4 changed the title Added a Gallery feat: added a gallery Mar 25, 2024
@thulieblack
Copy link
Member

@Kavisha4 please resolve your conflicts

@Kavisha4
Copy link
Author

@Kavisha4 please resolve your conflicts

Hi, yes I have resolved them! The checks are passing now

@AceTheCreator
Copy link
Member

@Kavisha4 Still willing to improve this PR?

@Mayaleeeee
Copy link
Member

Is there any update on this, @Kavisha4?

@Kavisha4
Copy link
Author

Kavisha4 commented Apr 9, 2024

Is there any update on this, @Kavisha4?

@Kavisha4 Still willing to improve this PR?

The gallery has been added using Javascript library: Masonry

Copy link
Member

@Mayaleeeee Mayaleeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having each image stand on its on in the screenshot below,
Screenshots_2024-05-21-07-41-11.png

Let's have all the images in a big frame with the title - Gallery on it.
See this Screenshots_2024-05-21-07-41-46.png

@Kavisha4
Copy link
Author

Instead of having each image stand on its on in the screenshot below, Screenshots_2024-05-21-07-41-11.png

Let's have all the images in a big frame with the title - Gallery on it. See this Screenshots_2024-05-21-07-41-46.png

I have exams going on, willing to work on it after a couple of days

@thulieblack
Copy link
Member

@Kavisha4 please resolve the conflicts

@thulieblack
Copy link
Member

We have another contributor working on this, since there has been no updates. Closing the pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants