Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add new maintainers.yaml file with tsc_members.json data #720

Merged
merged 25 commits into from
Jul 5, 2023

Conversation

14Richa
Copy link
Contributor

@14Richa 14Richa commented May 26, 2023

Description

This PR adds a new YAML file named MAINTAINERS.yaml. The MAINTAINERS.yaml file includes the data from the existing tsc_members.json file, but in YAML format. It also includes an update to the update-website-tsc.yaml workflow to accept the new YAML file instead of the old JSON file.

Additionally, the conversion from YAML to JSON is being done using Python.

I have tested this locally to ensure that the conversion works correctly. Here is the link to the local test results: https://github.com/14Richa/testRepo/actions/runs/5421542255/jobs/9857107425

Related issue(s)
#210

@14Richa 14Richa marked this pull request as ready for review June 22, 2023 14:25
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can merge this PR during the maintainership, even if not all automation is in place, but that requires also update to:

and also you need to change

yes 🤯 I was talking about validation of the file against json schema, that it would be nice.....and I just figured that we already have it 🤯 so just small adjustment is needed, new isTscMember filed added to json schema, and overall naming change in the workflow

MAINTAINERS.yaml Show resolved Hide resolved
.github/workflows/update-website-tsc.yml Outdated Show resolved Hide resolved
.github/workflows/update-website-tsc.yml Show resolved Hide resolved
@14Richa
Copy link
Contributor Author

14Richa commented Jul 3, 2023

@derberg, I have updated the workflow, and now it triggers when changes are made to MAINTAINERS.yaml. I have tested it in my test repository. Here are the logs : https://github.com/14Richa/testRepo/actions/runs/5446678618/jobs/9907756968

Additionally, I have updated the validate-tsc-member.yaml workflow, renamed it to validate-maintainer.yaml, and made some changes to it. As discussed above, I have also added a new field in the schema named isTscMember. Moreover, I have made minor changes to the schema file overall.

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good quality updates to the PR 👏🏼

left few minors

.github/workflows/tsc_members_validator/schema.json Outdated Show resolved Hide resolved
.github/workflows/msg-to-new-member-pr-merged.yml Outdated Show resolved Hide resolved
.github/workflows/validate-maintainers.yml Outdated Show resolved Hide resolved
@14Richa 14Richa requested a review from thulieblack as a code owner July 5, 2023 09:07
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
derberg
derberg previously approved these changes Jul 5, 2023
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🚀

@derberg
Copy link
Member

derberg commented Jul 5, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit 0f2ce62 into asyncapi:master Jul 5, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants