feat: add workflow for automated vote notification #1337
Conversation
|
/u |
|
Sample message: |
Shurtu-gal
requested review from
derberg,
asyncapi-bot-eve and
thulieblack
as code owners
|
/ptal |
|
@derberg @thulieblack Please take a look at this PR. Thanks! 👋 |
| for (const member of leftToVote) { | ||
| console.log(`Notifying ${member.name} about issue #${issue.number}`); | ||
|
|
||
| const message = `👋 Hi ${member.name},\nYour vote is required on the following issue: *#${issue.number}*.\n*Issue Details*: <${issue.html_url}|View and cast your vote here>\nYour input is crucial to our decision-making process. Please take a moment to review the issue and share your thoughts.\nThank you for your contribution! 🙏`; |
There was a problem hiding this comment.
| const message = `👋 Hi ${member.name},\nYour vote is required on the following issue: *#${issue.number}*.\n*Issue Details*: <${issue.html_url}|View and cast your vote here>\nYour input is crucial to our decision-making process. Please take a moment to review the issue and share your thoughts.\nThank you for your contribution! 🙏`; | |
| const message = `👋 Hi ${member.name},\nWe need your vote on the following topic: *${issue.title}*.\n*Issue Details*: ${issue.html_url}\nYour input is crucial to our decision-making process. Please take a moment to review the voting topic and share your thoughts.\nThank you for your contribution! 🙏`; |
small suggestion above:
- it is not always issue
issue.titleI invented this one, not sure if property like this is there, so yeah please just make sure we provide the title of issue/pr- I tried to suggest a change to show the link without alt
| id: list | ||
| with: | ||
| script: | | ||
| const { data: issues } = await github.rest.issues.listForRepo({ |
There was a problem hiding this comment.
I don't think so does gitvote allow PR voting as well?
There was a problem hiding this comment.
Facing a problem with PRs though, getting filtered results by vote-open label is not possible. Should I go ahead with manually filtering the whole list of PRs.
| - name: Fetch Current State | ||
| id: fetch | ||
| run: | | ||
| cd .vote_state |
There was a problem hiding this comment.
A branch stores the data between workflow runs https://github.com/ash17290/asyncapi-community/tree/vote_state
| text: message, | ||
| }, { | ||
| headers: { | ||
| 'Authorization': `Bearer ${{ secrets.SLACK_TOKEN }}`, |
There was a problem hiding this comment.
we use existing one, no need to do anything here, right?
There was a problem hiding this comment.
Yeah, regarding this I don't know which secret has access to post messages. Need chat:write to be specific. For more info:
https://api.slack.com/methods/chat.postMessage
There was a problem hiding this comment.
@Shurtu-gal left few comments, thanks a lot!
I think it is ok to make first version based on slack, and in the meantime we need to discuss with TSC if they feel fine sharing emails openly in maintainers.yml
Description
Related issue(s)
Closes #1163