-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update MAINTAINERS.yaml for each CODEOWNERS file change #1315
Conversation
@asyncapi/bounty_team |
88b7c63
to
01322ca
Compare
don't worry about what actions for slack notifications is better -> we are not very consistent in this area 😄 -> https://github.com/asyncapi/.github/blob/master/.github/workflows/automerge-orphans.yml#L61 |
01322ca
to
255d2e7
Compare
Thank you for the review! 🙇 Here is the 255d2e7 commit that contains the following changes:
Here is the GitHub run where I tested the all provided changes: https://github.com/refresh-maintainers-demo/community/actions/runs/10134304231/job/28020379271 |
Hi 👋
Here is the GitHub run where I tested the all provided changes: https://github.com/refresh-maintainers-demo/community/actions/runs/10211359115/job/28252539643 Cheers! |
/ptal |
@thulieblack Please take a look at this PR. Thanks! 👋 |
I was PTALing mostly @derberg, but the code is good; why not make everyone look at it, sure? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @mszostok !!! and sorry for delay, holidays 😉
/rtm |
Description
community
repository.Notes for Reviewer
Please watch the attached demo recordings:
MAINTAINERS.yaml
by user triggerMAINTAINERS.yaml
update whenCODEOWNERS
changes are mergedPlease check the README.md which describes how it works.
Click to see the flow diagram
I used the
rtCamp/action-slack-notify
action; however, I also saw that you use8398a7/action-slack
. Let me know if I should switch to it.To keep the code simple, a full refresh is performed. This doesn't introduce any additional risks:
CODEOWNERS
file change from a single repository, it will use just 1 call.Related Issue(s)
Blocked by: #1314 and asyncapi/github-action-for-cli#397
Fixes: #1269