Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removed the focus: outline-none and added a visible focus. #1065

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+4 −4
Open

fix: removed the focus: outline-none and added a visible focus. #1065

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1083885
added visible focus to the button
ItshMoh Oct 3, 2024
e187550
added visible focus according to theme.
ItshMoh Oct 5, 2024
f6603a5
Merge branch 'master' into focus_button
AceTheCreator Oct 7, 2024
120514d
Merge branch 'master' into focus_button
AceTheCreator Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion library/src/components/CollapseButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const CollapseButton: React.FunctionComponent<Props> = ({
}) => (
<button
{...rest}
className={`focus:outline-none ${rest.className}`}
className={`focus:ring-2 focus:ring-blue-500 focus:ring-offset-2 ${rest.className}`}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here instead of using blue-500 color variant how's about using something which matches with the existing theme ?

type="button"
>
<div className="inline-block">{children}</div>
Expand Down
2 changes: 1 addition & 1 deletion library/src/containers/Messages/MessageExample.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export const Example: React.FunctionComponent<ExampleProps> = ({
className: 'fill-current text-gray-200',
}}
>
<span className="inline-block w-20 py-0.5 mr-1 text-gray-200 text-sm border text-center rounded focus:outline-none">
<span className="inline-block w-20 py-0.5 mr-1 text-gray-200 text-sm border text-center rounded focus:ring-2 focus:ring-blue-500 focus:ring-offset-2">
{type}
</span>
</CollapseButton>
Expand Down
4 changes: 2 additions & 2 deletions library/src/containers/Operations/Operation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ export const OperationReplyInfo: React.FunctionComponent<Props> = (props) => {
onClick={() => setShowChannel((prev) => !prev)}
expanded={showChannel}
>
<span className="inline-block py-0.5 mr-1 text-gray-500 text-xs text-center rounded focus:outline-none">
<span className="inline-block py-0.5 mr-1 text-gray-500 text-xs text-center rounded focus:ring-2 focus:ring-blue-500 focus:ring-offset-2">
View channel details
</span>
</CollapseButton>
Expand All @@ -324,7 +324,7 @@ export const OperationReplyInfo: React.FunctionComponent<Props> = (props) => {
onClick={() => setShowMessages((prev) => !prev)}
expanded={showMessages}
>
<span className="inline-block py-0.5 mr-1 text-gray-500 text-xs text-center rounded focus:outline-none">
<span className="inline-block py-0.5 mr-1 text-gray-500 text-xs text-center rounded focus:ring-2 focus:ring-blue-500 focus:ring-offset-2">
Expected Reply{' '}
{replyMessages.length > 1 ? 'Messages' : 'Message'}
</span>
Expand Down
Loading