Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed the focus: outline-none and added a visible focus. #1065

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

ItshMoh
Copy link
Contributor

@ItshMoh ItshMoh commented Oct 3, 2024

Removed the focus: outline-none and added a visible focus to the buttons.

Description

Related issue(s)
#958
button_focus

@@ -33,7 +33,7 @@ export const CollapseButton: React.FunctionComponent<Props> = ({
}) => (
<button
{...rest}
className={`focus:outline-none ${rest.className}`}
className={`focus:ring-2 focus:ring-blue-500 focus:ring-offset-2 ${rest.className}`}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here instead of using blue-500 color variant how's about using something which matches with the existing theme ?

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use a color that matches with the existing theme

Copy link

sonarcloud bot commented Oct 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants