Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP/proposal: plotting for compound artists #470

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

keflavich
Copy link
Contributor

Fix for #469. A little more documentation, and some testing, is needed.

@larrybradley what do you think of this general approach? .plot stays transparent to users (though now can return lists), but Composite regions behave differently from other regions by default (except for annuli, which already have their own special case).

@keflavich keflavich marked this pull request as draft July 15, 2022 07:59
Copy link
Member

@larrybradley larrybradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this approach may be the best we can do. One issue is that the returned patches will represent each component of the compound shape instead of single patch/path representing the outline of the compound shape. But I think it would be challenging to implement that in a general way for all possible compound shapes.

@keflavich
Copy link
Contributor Author

Yeah, that's where I landed on this. It's been a while since I worked on this PR - I think I was waiting for your go-ahead before doing any more work, but probably all that's needed are some tests & documentation? (...which is twice as much as what's already here...)

@larrybradley
Copy link
Member

Yeah, docs and tests are needed. Also, an example with a plot would be helpful, also explaining the caveats above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants