Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: adding pyhon 3.12 and other CI cleanup #71

Merged
merged 5 commits into from
Aug 23, 2023

Conversation

bsipocz
Copy link
Member

@bsipocz bsipocz commented Aug 23, 2023

Extending CI matrix with new versions, adding python 3.12, and other minor cleanups.
This should go into the next release.

I have changes that remove python 3.7 support for a separate PR, which should go in once the next release is out.

@bsipocz bsipocz added this to the 0.4.1 milestone Aug 23, 2023
Copy link
Member

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@@ -7,8 +7,8 @@ on:
tags:
workflow_dispatch:
schedule:
# Run every Sunday at 03:53 UTC
- cron: 53 3 * * 0
# Run every Tuesday at 03:53 UTC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, sorry to traumatize you like this. 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh 😂
you shouldn't receive failing ci notifications on a weekend either, the only place where we should run them on a weekend is when they ping third-party servers.

@pllim pllim merged commit 485b845 into astropy:main Aug 23, 2023
15 checks passed
@bsipocz bsipocz deleted the MAINT_adding_py312 branch August 23, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants