Replace deprecated code #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`threading.Thread.setDaemon()` method is deprecated since Python 3.10. The recommended solution is setting the `threading.Thread.daemon` attribute directly, and that works for all versions of Python supported by this plugin.
|
There is |
Now that `pytest` is configured to treat uncaught warnings as exceptions not closing a server used in a test caused the test suite to fail with a `ResourceWarning`.
|
I needed to add a third commit with cleanup code to make all the tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit replaces a method call that is deprecated since Python 3.10 and fixes #68. The second commit configures
pytestto convert uncaught warnings to errors, which would have revealed the deprecation earlier.