ENH: Adding cmd line -R option #62
Conversation
|
close and reopen to trigger CI |
| - os: macos-latest | ||
| python-version: 3.8 | ||
| toxenv: py38-test-pytestdev | ||
| python-version: '3.10' |
There was a problem hiding this comment.
Sure, but it's enough to have it once the release is out
| parser.addoption( | ||
| "--remote-data", nargs="?", const='any', default='none', | ||
| "--remote-data", "-R", nargs="?", const='any', default='none', |
There was a problem hiding this comment.
I didn't check but we had a past problem where we accidentally overrode an existing shortcut from upstream. Are you sure this won't conflict with other stuff?
There was a problem hiding this comment.
yep, I'm sure, that was one of the other ones. There maybe override with other plugins, but not with core pytest or the ones I have installed:
$ ~/munka/devel/astroquery [esasky-doc-cleanup|…1⚑ 19] $ pytest -R
ERROR: usage: pytest [options] [file_or_dir] [file_or_dir] [...]
pytest: error: unrecognized arguments: -R
inifile: /Users/bsipocz/munka/devel/astroquery/setup.cfg
rootdir: /Users/bsipocz/munka/devel/astroquery
plugins: anyio-3.6.1, remotedata-0.3.3, requests-mock-1.9.3, rerunfailures-10.2, astropy-header-0.2.2, doctestplus-0.12.1, mock-3.8.2, dependency-0.5.1, astropy-0.10.0, filter-subpackage-0.1.1, openfiles-0.5.0, nbval-0.9.7.dev0, hypothesis-6.54.5, cov-3.0.0, arraydiff-0.5.0
There was a problem hiding this comment.
Thanks for checking! We can revisit this in the future if a conflict does arise I hope not. 😸
| - os: macos-latest | ||
| python-version: 3.8 | ||
| toxenv: py38-test-pytestdev | ||
| python-version: '3.10' |
| parser.addoption( | ||
| "--remote-data", nargs="?", const='any', default='none', | ||
| "--remote-data", "-R", nargs="?", const='any', default='none', |
There was a problem hiding this comment.
Thanks for checking! We can revisit this in the future if a conflict does arise I hope not. 😸
|
And even the changelog addition was waiting for it in |
To close #46
Also, I did minor cleanups for ancient python versions, etc.